Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: eslint:recommended changes (fixes #10768) #11518

Merged
merged 2 commits into from Apr 26, 2019

Conversation

Projects
4 participants
@aladdin-add
Copy link
Member

commented Mar 17, 2019

What is the purpose of this pull request? (put an "X" next to item)

[x ] Other, please explain: fixes #10768

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

any objections on the rules?

aladdin-add added some commits Mar 17, 2019

@not-an-aardvark
Copy link
Member

left a comment

LGTM aside from a small suggestion.

@not-an-aardvark
Copy link
Member

left a comment

LGTM, thanks!

@not-an-aardvark

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

Adding "do not merge" for now to make sure we agree on the rule suggestions from #10768 (comment) before merging.

@ljharb

ljharb approved these changes Mar 18, 2019

Show resolved Hide resolved lib/rules/no-console.js

@mysticatea mysticatea added this to Implemented, pending review in v6.0.0 Mar 27, 2019

@teppeis teppeis referenced this pull request Apr 13, 2019

Merged

fix: update eslint to v6 alpha #260

1 of 2 tasks complete

@not-an-aardvark not-an-aardvark merged commit 0fc8e62 into eslint:master Apr 26, 2019

6 checks passed

commit-message PR title follows commit message guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
wip This PR is no longer a work in progress
Details

v6.0.0 automation moved this from Implemented, pending review to Done Apr 26, 2019

@aladdin-add aladdin-add deleted the aladdin-add:issue10768 branch Apr 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.