Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Breaking: fix config loading (fixes #11510, fixes #11559, fixes #11586) #11546
What is the purpose of this pull request? (put an "X" next to item)
What changes did you make? (Give an overview)
This PR fixes three bugs along with the refactoring of configurations.
All new files are in
The refactoring does the following items:
I describe file mapping of before/after the refactoring. There are details for each new file on the top of the source code.
Therefore, appropriate tests to the moved logics are moved to new files.
And I added some
Is there anything you'd like reviewers to focus on?
I found an additional breaking change (as a bug fix) about plugin loading. Currently, even if a configuration has no
Related to that,
I think that this change is good because formatters can access to unrelated rules (via RFC 10) before this PR and we already have a getter to get information of the last