Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Chore: Add linting to git commit #11556
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
Infrastructure - add git commit hook
What changes did you make? (Give an overview)
Added an installable pre-commit hook that automatically runs ESLint when
The hook automatically runs ESLint with
Is there anything you'd like reviewers to focus on?
Is this useful to you? I find it useful because I have a bad habit of forgetting to run ESLint before updating my commit.
Is this opt-in, or does it automatically get installed as a git hook? Personally, I often create WIP local commits before fixing lint errors, so I probably wouldn't want to have this running locally, but I'm fine with it if it doesn't get installed automatically and/or if there's a way to disable it.
@not-an-aardvark It gets installed automatically, but you can skip it using
@aladdin-add It's probably a good idea to mention that there is some verification going on, though I wouldn't want to tell people how to bypass it because 1) most of the time, you shouldn't bypass it and 2) the console tells you how to bypass the check if there's an error.