Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: karma@^4.0.1, drops Node 6 support, fixes vulnerability #11570

Merged
merged 1 commit into from Apr 2, 2019

Conversation

Projects
None yet
4 participants
@platinumazure
Copy link
Member

commented Mar 30, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Dev dependency upgrade

What changes did you make? (Give an overview)

Upgrade to karma@^4.0.1. This fixes some npm-reported security vulnerabilities.

Is there anything you'd like reviewers to focus on?

This version of Karma drops support for Node 6, so it would be a breaking change. I am not labeling this "Breaking" because I assume this can be merged after #11557 is merged. (Labeling "do not merge" here instead.)

@platinumazure

This comment has been minimized.

Copy link
Member Author

commented Apr 1, 2019

Closing and reopening this PR to force Travis rerun. (My GitHub SSO isn't working on Travis, and also we've changed the config to drop Node 6 so I'm not sure how well a restart would go anyway.)

@aladdin-add
Copy link
Member

left a comment

LGTM, thanks!

@not-an-aardvark not-an-aardvark merged commit 3396c3e into master Apr 2, 2019

6 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
wip This PR is no longer a work in progress
Details

@not-an-aardvark not-an-aardvark deleted the upgrade-karma branch Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.