Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: upgrade espree to 6.0.0-alpha.0 (fixes #9687) #11610

Merged
merged 1 commit into from Apr 13, 2019

Conversation

Projects
2 participants
@not-an-aardvark
Copy link
Member

commented Apr 13, 2019

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

This updates espree to v6.0.0-alpha.0, which fixes #9687.

Is there anything you'd like reviewers to focus on?

Nothing in particular

@not-an-aardvark not-an-aardvark added this to Implemented, pending review in v6.0.0 Apr 13, 2019

@not-an-aardvark not-an-aardvark merged commit 9e49b56 into master Apr 13, 2019

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

v6.0.0 automation moved this from Implemented, pending review to Done Apr 13, 2019

@not-an-aardvark not-an-aardvark deleted the upgrade-espree-to-alpha branch Apr 13, 2019

aladdin-add added a commit to aladdin-add/eslint that referenced this pull request Apr 24, 2019

Fix: validate parserOptions ecmaVersion & sourceType (fixes eslint#9687)
PR eslint#11610 was aimed to fix the issue eslint#9687, however it did not work,
since ecmaVersion has been normalized to 6 (when sourceType is setting to 'module').

this PR removed the normalize behaviour, and fixed failing tests.

aladdin-add added a commit to aladdin-add/eslint that referenced this pull request Apr 27, 2019

Fix: validate parserOptions ecmaVersion & sourceType (fixes eslint#9687)
PR eslint#11610 was aimed to fix the issue eslint#9687, however it did not work,
since ecmaVersion has been normalized to 6 (when sourceType is setting to 'module').

this PR removed the normalize behaviour, and fixed failing tests.

aladdin-add added a commit to aladdin-add/eslint that referenced this pull request May 10, 2019

Fix: validate parserOptions ecmaVersion & sourceType (fixes eslint#9687)
PR eslint#11610 was aimed to fix the issue eslint#9687, however it did not work,
since ecmaVersion has been normalized to 6 (when sourceType is setting to 'module').

this PR removed the normalize behaviour, and fixed failing tests.

not-an-aardvark added a commit that referenced this pull request May 11, 2019

Fix: not set ecmaVersion to 6 when sourceType=module (fixes #9687) (#…
…11649)

PR #11610 was aimed to fix the issue #9687, however it did not work,
since ecmaVersion has been normalized to 6 (when sourceType is setting to 'module').

this PR removed the normalize behaviour, and fixed failing tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.