Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: autofix of no-unneeded-ternary made syntax error (fixes #11579) #11616

Merged
merged 1 commit into from Apr 19, 2019

Conversation

Projects
None yet
2 participants
@mysticatea
Copy link
Member

commented Apr 13, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix

What changes did you make? (Give an overview)

This PR fixes #11579.
The new logic uses operator precedence instead of whitelist of node types in order to check the necessity of parenthesizing.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@platinumazure
Copy link
Member

left a comment

LGTM, thanks!

@mysticatea mysticatea merged commit 1dfe077 into master Apr 19, 2019

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@mysticatea mysticatea deleted the issue11579 branch Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.