Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: delete unnecessary duplicated question (fixes #11617) #11618

Merged
merged 3 commits into from May 11, 2019

Conversation

Projects
None yet
6 participants
@7ma7X
Copy link
Contributor

commented Apr 14, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

fix #11617

Is there anything you'd like reviewers to focus on?

@jsf-clabot

This comment has been minimized.

Copy link

commented Apr 14, 2019

CLA assistant check
All committers have signed the CLA.

@eslint eslint bot added the triage label Apr 14, 2019

@g-plane g-plane added bug evaluating and removed triage labels Apr 14, 2019

@mysticatea mysticatea changed the title delete unnecessary duplicated question Fix: delete unnecessary duplicated question (fixes #11617) Apr 14, 2019

@platinumazure

This comment has been minimized.

Copy link
Member

commented Apr 14, 2019

Hi @7ma7X, thanks for contributing!

Out of curiosity, was there a particular reason for choosing to delete the second version of the question? Was it just because it was the second one? Or have you considered the flow of questions and consider the first location to make more sense overall?

I personally could see an argument for asking this question last, as the answer has no bearing on anything else except for the writing of the config file.

@g-plane

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

The second one seems duplicated.

@7ma7X

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

@platinumazure

The latter question will appear only if you choose Answer questions about your style to the question How would you like to define a style for your project?.
As this format question must be present in any case, the former question should be left as it is, I guess.

@platinumazure

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

@7ma7X Awesome answer! Thanks for humoring me. 😄

@platinumazure
Copy link
Member

left a comment

LGTM, thanks!

@7ma7X

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

modified commit message to keep with the commit-message guidlines

@platinumazure platinumazure requested a review from nzakas Apr 15, 2019

@not-an-aardvark
Copy link
Member

left a comment

LGTM, thanks!

@ilyavolodin ilyavolodin merged commit 252efd3 into eslint:master May 11, 2019

5 checks passed

commit-message PR title follows commit message guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.