Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: introduce minKeys option to sort-keys rule (fixes #11624) #11625

Merged
merged 2 commits into from Jun 8, 2019

Conversation

Projects
None yet
5 participants
@csantos42
Copy link
Contributor

commented Apr 17, 2019

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Fixes #11624

What changes did you make? (Give an overview)
Modified the sort-keys rule to accept a minKeys option, which specifies minimum number of keys required for an object's unsorted keys to produce an error. Default for the option is 2.

Documentation has been updated and tests have been written.

Is there anything you'd like reviewers to focus on?
Nothing in particular, lucky for me this turned out to be a small change.

@eslint eslint bot added the triage label Apr 17, 2019

@kaicataldo kaicataldo added accepted and removed evaluating labels May 29, 2019

@platinumazure
Copy link
Member

left a comment

LGTM, thanks!

@platinumazure platinumazure requested a review from ilyavolodin Jun 8, 2019

@platinumazure platinumazure merged commit f403b07 into eslint:master Jun 8, 2019

5 checks passed

commit-message PR title follows commit message guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.