Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add missing items to migration guide #11628

Merged
merged 2 commits into from Apr 26, 2019

Conversation

Projects
3 participants
@not-an-aardvark
Copy link
Member

commented Apr 18, 2019

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update

What changes did you make? (Give an overview)

This updates the migration guide to add the missing items mentioned in #11515 (comment).

It does not add #9505 yet because there is some debate about whether that feature will still make it into the release.

Is there anything you'd like reviewers to focus on?

@not-an-aardvark not-an-aardvark added this to Implemented, pending review in v6.0.0 Apr 18, 2019

@platinumazure
Copy link
Member

left a comment

One typo, otherwise LGTM. Thanks for putting this together!

Show resolved Hide resolved docs/user-guide/migrating-to-6.0.0.md Outdated

@not-an-aardvark not-an-aardvark merged commit eef71e4 into master Apr 26, 2019

5 checks passed

commit-message PR title follows commit message guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

v6.0.0 automation moved this from Implemented, pending review to Done Apr 26, 2019

@not-an-aardvark not-an-aardvark deleted the update-migration-guide branch Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.