Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: fix CLIEngine tests when os.tmpdir is a symlink #11697

Merged
merged 1 commit into from May 10, 2019

Conversation

Projects
None yet
2 participants
@not-an-aardvark
Copy link
Member

commented May 10, 2019

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

This fixes a test failure on macOS. Previously, some CLIEngine tests were failing because some parts of the CLIEngine tests call realpath() and others didn't.

Is there anything you'd like reviewers to focus on?

Nothing in particular

Chore: fix CLIEngine tests when os.tmpdir is a symlink
Previously, this was causing test failures on macOS because some parts of the CLIEngine tests call realpath() and others didn't.
@mysticatea
Copy link
Member

left a comment

LGTM, thank you.

@not-an-aardvark not-an-aardvark merged commit f5bae78 into master May 10, 2019

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@not-an-aardvark not-an-aardvark deleted the fix-cli-engine-tests branch May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.