Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: add `endColumn` to no-useless-escape (fixes #11629) #11790

Merged
merged 1 commit into from Jun 2, 2019

Conversation

Projects
None yet
4 participants
@g-plane
Copy link
Member

commented May 30, 2019

What is the purpose of this pull request? (put an "X" next to item)

[x] Changes an existing rule

What changes did you make? (Give an overview)
Fixes #11629 .

Is there anything you'd like reviewers to focus on?
Nothing.

@platinumazure
Copy link
Member

left a comment

LGTM, thanks!

@kaicataldo
Copy link
Member

left a comment

LGTM

@platinumazure platinumazure merged commit 37e5193 into master Jun 2, 2019

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@platinumazure

This comment has been minimized.

Copy link
Member

commented Jun 2, 2019

Merged. Thanks for contributing!

@g-plane g-plane deleted the issue-11629 branch Jun 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.