Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: no-octal should report NonOctalDecimalIntegerLiteral (fixes #11794) #11805

Merged
merged 1 commit into from Jun 8, 2019

Conversation

Projects
None yet
4 participants
@mdjermanovic
Copy link
Contributor

commented Jun 4, 2019

Examples: 08, 018, 08.1

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix: #11794

What changes did you make? (Give an overview)

Reference: ECMAScript Additional Syntax Numeric Literals

no-octal rule used to report all LegacyOctalIntegerLiteral literals (00, 01, 071...) and only some NonOctalDecimalIntegerLiteral literals (018...).

The rule didn't report NonOctalDecimalIntegerLiteral literals that start with 08 or 09.

With this fix, the rule will report all LegacyOctalIntegerLiteral and all NonOctalDecimalIntegerLiteral literals as well as all DecimalLiteral literals that contain them (e.g. 08.1, 08e1...).

Is there anything you'd like reviewers to focus on?

@eslint eslint bot added the triage label Jun 4, 2019

@platinumazure
Copy link
Member

left a comment

LGTM, thanks!

@platinumazure platinumazure added accepted bug rule and removed triage labels Jun 4, 2019

@aladdin-add
Copy link
Member

left a comment

LGTM, thanks!

@platinumazure platinumazure requested a review from ilyavolodin Jun 8, 2019

@platinumazure platinumazure merged commit 87451f4 into eslint:master Jun 8, 2019

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.