Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix: no-octal should report NonOctalDecimalIntegerLiteral (fixes #11794) #11805
Examples: 08, 018, 08.1
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix: #11794
What changes did you make? (Give an overview)
no-octal rule used to report all LegacyOctalIntegerLiteral literals (00, 01, 071...) and only some NonOctalDecimalIntegerLiteral literals (018...).
The rule didn't report NonOctalDecimalIntegerLiteral literals that start with 08 or 09.
With this fix, the rule will report all LegacyOctalIntegerLiteral and all NonOctalDecimalIntegerLiteral literals as well as all DecimalLiteral literals that contain them (e.g. 08.1, 08e1...).
Is there anything you'd like reviewers to focus on?