Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CLIEngine#getRules() contains plugin rules (fixes #11871) #11872

Merged
merged 1 commit into from Jun 23, 2019

Conversation

Projects
5 participants
@mysticatea
Copy link
Member

commented Jun 22, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix: #11871

What changes did you make? (Give an overview)

This PR fixes CLIEngine as the following code contains plugin rules.

new CLIEngine({ plugins: ['foo'] }).getRules()

Previously, CLIEngine#getRules() contains core rules and the plugin rules that the last CLIEngine#executeOn*() methods call used.

This PR changes only the behavior that is before CLIEngine#executeOn*() methods called.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@mysticatea mysticatea added this to Implemented, pending review in v6.0.0 Jun 22, 2019

@platinumazure
Copy link
Member

left a comment

LGTM, thanks!

In your view, should this be a patch release candidate?

@mysticatea

This comment has been minimized.

Copy link
Member Author

commented Jun 22, 2019

Yes, I think so.

@mysticatea mysticatea merged commit d07f3fa into master Jun 23, 2019

9 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration Build #20190622.7 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor This change is semver-patch
Details

v6.0.0 automation moved this from Implemented, pending review to Done Jun 23, 2019

@mysticatea mysticatea deleted the issue11871 branch Jun 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.