Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix inconsistent linking in migration guide #11881

Merged
merged 1 commit into from Jun 22, 2019

Conversation

Projects
None yet
3 participants
@not-an-aardvark
Copy link
Member

commented Jun 22, 2019

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update

What changes did you make? (Give an overview)

This fixes some inconsistent formatting in the migration guide. Previously, the comma-dangle header was blue (and a link to itself) while all the other headers were not.

Is there anything you'd like reviewers to focus on?

Nothing in particular

@not-an-aardvark not-an-aardvark merged commit 21f4a80 into master Jun 22, 2019

9 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration Build #20190622.10 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor This change is semver-patch
Details

@not-an-aardvark not-an-aardvark deleted the fix-inconsistent-migration-guide-link branch Jun 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.