Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: improve error message on --print-config (fixes #11874) #11885

Merged
merged 2 commits into from Jun 25, 2019

Conversation

Projects
None yet
4 participants
@mysticatea
Copy link
Member

commented Jun 23, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix #11874

What changes did you make? (Give an overview)

This PR fixes the error message when people used --print-config with a directory path.

> eslint --print-config .     

Oops! Something went wrong! :(

ESLint: 6.0.0.

'--print-config' CLI option requires a path to a source code file rather than a directory.
See also: https://eslint.org/docs/user-guide/command-line-interface#--print-config

Is there anything you'd like reviewers to focus on?

Is this direction correct?

@not-an-aardvark
Copy link
Member

left a comment

LGTM, thanks! I have a small suggestion to improve the error message.

Show resolved Hide resolved messages/print-config-with-directory-path.txt Outdated
Update messages/print-config-with-directory-path.txt
Co-Authored-By: Teddy Katz <teddy.katz@gmail.com>

@kaicataldo kaicataldo added accepted bug and removed bug evaluating labels Jun 24, 2019

@platinumazure

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

Adding "patch candidate" label to ensure this gets in to the upcoming patch release (although this PR by itself would not normally justify a patch release).

@not-an-aardvark not-an-aardvark merged commit 13f0418 into master Jun 25, 2019

9 checks passed

commit-message PR title follows commit message guidelines
Details
continuous-integration Build #20190624.1 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor This change is semver-patch
Details

@not-an-aardvark not-an-aardvark deleted the issue11874 branch Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.