Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update no-confusing-arrow with the new default option #11886

Merged
merged 2 commits into from Jun 24, 2019

Conversation

Projects
None yet
7 participants
@zypA13510
Copy link
Contributor

commented Jun 24, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

  • Removed redundant sentence from the summary as the default for allowParens is now true.
  • Updated examples according to the new default.

Is there anything you'd like reviewers to focus on?
N/A

Docs: Update examples with the new default option (refs #11503)
- Remove redundant sentence from the summary as the default for allowParens is now true.
- Update examples according to the new default.
@jsf-clabot

This comment has been minimized.

Copy link

commented Jun 24, 2019

CLA assistant check
All committers have signed the CLA.

@eslint eslint bot added the triage label Jun 24, 2019

@zypA13510 zypA13510 changed the title Docs: Update examples with the new default option (refs #11503) Docs: Update no-confusing-arrow with the new default option Jun 24, 2019

@g-plane
Copy link
Member

left a comment

Left one change requesting. Other changes look good, thanks!

Show resolved Hide resolved docs/rules/no-confusing-arrow.md Outdated

@g-plane g-plane added documentation and removed triage labels Jun 24, 2019

@g-plane

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

And, please sign our CLA.

Docs: Fix examples
- Moved an example from correct to incorrect.
- Added a new correct example.
@zypA13510

This comment has been minimized.

Copy link
Contributor Author

commented Jun 24, 2019

Done, also added a new example because it seems appropriate to me.

@g-plane
Copy link
Member

left a comment

Thanks for contributing!

@aladdin-add
Copy link
Member

left a comment

LGTM, thanks!

@platinumazure
Copy link
Member

left a comment

LGTM, thanks!

@kaicataldo
Copy link
Member

left a comment

Thanks for contributing to ESLint!

@kaicataldo kaicataldo merged commit 566b7aa into eslint:master Jun 24, 2019

9 checks passed

commit-message PR title follows commit message guidelines
Details
continuous-integration Build #20190624.3 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor This change is semver-patch
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.