Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: --rulesdir option didn't work (fixes #11888) #11890

Merged
merged 1 commit into from Jun 25, 2019

Conversation

Projects
None yet
6 participants
@mysticatea
Copy link
Member

commented Jun 24, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix: #11888

What changes did you make? (Give an overview)

This PR fixes a bug that CLEngine ignored baseConfig and rulePaths if a config file has root:true.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@aladdin-add

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

the build failing somehow, but seems not related to this change.

@mysticatea

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2019

Some cloud services look bad condition currently (I have seen Netlify timed out on other repos).

@not-an-aardvark not-an-aardvark merged commit b5bde06 into master Jun 25, 2019

9 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration Build #20190624.7 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor This change is semver-patch
Details

@not-an-aardvark not-an-aardvark deleted the issue11888 branch Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.