Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add 'stricter rule config validating' in migrating docs #11905

Merged
merged 2 commits into from Jun 26, 2019

Conversation

@aladdin-add
Copy link
Member

commented Jun 25, 2019

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update

What changes did you make? (Give an overview)
refs #9505

Is there anything you'd like reviewers to focus on?

wording improvement?

@aladdin-add aladdin-add force-pushed the aladdin-add:docs/rule-config-validating branch from f8f7d2b to df2421f Jun 25, 2019

@platinumazure platinumazure self-requested a review Jun 25, 2019

docs/user-guide/migrating-to-6.0.0.md Outdated Show resolved Hide resolved
docs/user-guide/migrating-to-6.0.0.md Outdated Show resolved Hide resolved
docs/user-guide/migrating-to-6.0.0.md Outdated Show resolved Hide resolved
@kaicataldo

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

A few comments, but otherwise LGTM!

@kaicataldo
Copy link
Member

left a comment

Thanks for doing this!

@platinumazure
Copy link
Member

left a comment

LGTM, thanks!

@g-plane
Copy link
Member

left a comment

Left one suggestion. Other changes look good, thanks!

docs/user-guide/migrating-to-6.0.0.md Show resolved Hide resolved

@kaicataldo kaicataldo merged commit e5f1ccc into eslint:master Jun 26, 2019

9 checks passed

commit-message PR title follows commit message guidelines
Details
continuous-integration Build #20190625.11 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@aladdin-add aladdin-add deleted the aladdin-add:docs/rule-config-validating branch Jun 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.