Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix no-extra-parens ignores some nodes #11909

Merged
merged 4 commits into from Aug 18, 2019
Merged

Conversation

@g-plane
Copy link
Member

g-plane commented Jun 26, 2019

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix

What changes did you make? (Give an overview)
Fixes #11893 .
Fixes #11906 .

Is there anything you'd like reviewers to focus on?

@eslint eslint bot added the triage label Jun 26, 2019
@g-plane g-plane added accepted bug rule and removed triage labels Jun 26, 2019
@g-plane g-plane marked this pull request as ready for review Jun 26, 2019
@mdjermanovic

This comment has been minimized.

Copy link
Member

mdjermanovic commented Jun 26, 2019

I'm not sure but maybe ${(a, b)} should be an error?

`${(1, 2)}` === "2"

`${1, 2}` === "2"
@g-plane

This comment has been minimized.

Copy link
Member Author

g-plane commented Jun 26, 2019

This shouldn't be reported.

@kaicataldo

This comment has been minimized.

Copy link
Member

kaicataldo commented Jun 26, 2019

@g-plane For the sake of discussion, can you share why you believe that shouldn’t be reported?

@g-plane

This comment has been minimized.

Copy link
Member Author

g-plane commented Jun 26, 2019

@kaicataldo Oh sorry, I misread it since I read it on my phone at that time.

Copy link
Member

platinumazure left a comment

LGTM, thanks!

@platinumazure platinumazure requested a review from mysticatea Jul 21, 2019
Copy link
Member

mysticatea left a comment

LGTM, thank you!

@g-plane Would you resolve conflicts?

@g-plane

This comment has been minimized.

Copy link
Member Author

g-plane commented Jul 21, 2019

Done.

Copy link
Member

kaicataldo left a comment

LGTM, thanks!

@platinumazure platinumazure merged commit 4cb7877 into master Aug 18, 2019
9 checks passed
9 checks passed
commit-message PR title follows commit message guidelines
Details
continuous-integration Build #20190721.8 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Aug 18, 2019

Merged. Thanks for contributing and sorry for the delay!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.