Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add parens for sequence expr in arrow-body-style (fixes #11917) #11918

Merged
merged 1 commit into from Jul 21, 2019

Conversation

@g-plane
Copy link
Member

commented Jun 28, 2019

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix

What changes did you make? (Give an overview)
Add parens for SequenceExpression.

Is there anything you'd like reviewers to focus on?

@eslint eslint bot added the triage label Jun 28, 2019

@g-plane g-plane added accepted bug rule and removed triage labels Jun 28, 2019

@kaicataldo
Copy link
Member

left a comment

LGTM. Thanks for contributing to ESLint!

@platinumazure platinumazure merged commit 79e8d09 into master Jul 21, 2019

9 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration Build #20190628.2 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@g-plane g-plane deleted the fix-11917 branch Jul 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.