Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix incorrect example comments for unicode-bom rule (fixes #11937) #11938

Merged
merged 2 commits into from Jul 3, 2019

Conversation

@BrandonYeager
Copy link
Contributor

commented Jul 3, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Fixed incorrect code comments in code examples for "unicode-bom" rule

Is there anything you'd like reviewers to focus on?
Comments in example code blocks (assuming wrong default)

@eslint eslint bot added the triage label Jul 3, 2019

@aladdin-add
Copy link
Member

left a comment

LGTM, thanks!

@platinumazure
Copy link
Member

left a comment

LGTM, thanks!

@BrandonYeager

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

Added the explicit default value back into the examples for the "never" option based on comments in the issue page.

@kaicataldo
Copy link
Member

left a comment

LGTM. Thanks for contributing to ESLint!

@platinumazure

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

I'm going to go ahead and merge. Thanks @BrandonYeager for contributing; every little bit helps and we really appreciate it!

@platinumazure platinumazure merged commit 8b216e0 into eslint:master Jul 3, 2019

9 checks passed

commit-message PR title follows commit message guidelines
Details
continuous-integration Build #20190703.6 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@BrandonYeager BrandonYeager deleted the BrandonYeager:issue11937 branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.