Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Replace global true and false with writable and readonly in rules #11956

Merged
merged 1 commit into from Jul 6, 2019

Conversation

@mdjermanovic
Copy link
Member

commented Jul 5, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update

What changes did you make? (Give an overview)

Replace in rule docs:

/*global a:false*/ with /*global a:readonly*/
/*global a:true*/ with /*global a:writable*/

as these are now the preferable option names and more expressive than their aliases.

Also replaced globals with global to be consistent with the configuring doc and other rules (except capitalized-comments where there are both).

Is there anything you'd like reviewers to focus on?

@eslint eslint bot added the triage label Jul 5, 2019

@g-plane g-plane added documentation and removed triage labels Jul 5, 2019

@kaicataldo
Copy link
Member

left a comment

LGTM. Thanks for contributing!

@platinumazure
Copy link
Member

left a comment

LGTM, thanks for doing this!

@aladdin-add aladdin-add merged commit c2f2db9 into eslint:master Jul 6, 2019

9 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration Build #20190705.4 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@aladdin-add

This comment has been minimized.

Copy link
Member

commented Jul 6, 2019

thanks for contributing! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.