Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: some typos and optimization points #11960

Merged
merged 1 commit into from Jul 14, 2019

Conversation

@molee1905
Copy link
Contributor

commented Jul 7, 2019

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

fix some typos and optimization points

Is there anything you'd like reviewers to focus on?

The "never" option of array-element-newline is not default option.

The "as-needed" option of func-names is not default option.

Both of them should remove default tag.

@eslint eslint bot added the triage label Jul 7, 2019

@g-plane g-plane added documentation and removed triage labels Jul 7, 2019

@g-plane

g-plane approved these changes Jul 7, 2019

Copy link
Member

left a comment

LGTM, thanks!

@platinumazure
Copy link
Member

left a comment

LGTM, thanks!

@aladdin-add
Copy link
Member

left a comment

LGTM, thanks!

@aladdin-add aladdin-add merged commit 4448261 into eslint:master Jul 14, 2019

9 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration Build #20190707.1 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.