Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add temporary test files to .gitignore #11978

Merged
merged 1 commit into from Jul 12, 2019

Conversation

@mdjermanovic
Copy link
Member

commented Jul 12, 2019

[X] Other, please explain:

These temporary files are being created during npm test, and could be accidentally committed:

  • .temp-eslintcache created in tests/bin/eslint.js in describe("cache files")
  • tests/fixtures/autofix-integration/temp.js created in tests/bin/eslint.js in describe("automatically fixing files")

What changes did you make? (Give an overview)

Added both to .gitignore

Is there anything you'd like reviewers to focus on?

Line endings, I got LF will be replaced by CRLF warning.

@eslint eslint bot added the triage label Jul 12, 2019

@g-plane g-plane added chore and removed triage labels Jul 12, 2019

@g-plane
Copy link
Member

left a comment

LGTM, thanks!

@kaicataldo kaicataldo merged commit 2a10856 into eslint:master Jul 12, 2019

9 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration Build #20190712.1 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@kaicataldo

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.