Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: --init with Vue.js failed (fixes #11970) #11985

Merged
merged 3 commits into from Jul 16, 2019

Conversation

@mysticatea
Copy link
Member

commented Jul 14, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix: #11970

What changes did you make? (Give an overview)

This PR fixes --init to work.

We didn't seem to test --init when we added Vue.js support. It has assumed that extends is a string and doesn't include plugin configs.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@platinumazure
Copy link
Member

left a comment

Just one change request, otherwise looks good to me.

lib/init/config-initializer.js Outdated Show resolved Hide resolved

mysticatea added some commits Jul 14, 2019

@mysticatea

This comment has been minimized.

Copy link
Member Author

commented Jul 14, 2019

Thank you for your review. I updated this PR.

@platinumazure
Copy link
Member

left a comment

LGTM, thanks!

@kaicataldo
Copy link
Member

left a comment

LGTM, thanks!

@kaicataldo kaicataldo merged commit 6669f78 into master Jul 16, 2019

9 checks passed

commit-message PR title follows commit message guidelines
Details
continuous-integration Build #20190714.5 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@kaicataldo kaicataldo deleted the fix-init-with-multiple-extends branch Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.