Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: glob processing (fixes #11940) #11986

Merged
merged 3 commits into from Jul 21, 2019

Conversation

@mysticatea
Copy link
Member

commented Jul 14, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix: #11940

What changes did you make? (Give an overview)

This PR fixes glob processing to iterate target files. The new way is similar to how shell passes globs to programs. I.e., if there are files that the glob matched, it adopts the matched files. Otherwise, it adopts the glob string as is.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@platinumazure
Copy link
Member

left a comment

LGTM, but would like more eyes on this change. Thanks!

mysticatea added some commits Jul 18, 2019

@mysticatea

This comment has been minimized.

Copy link
Member Author

commented Jul 18, 2019

OK. I updated this PR to follow @aladdin-add 's suggestion.

eslint [ab].js-like commands have different behaviors between Windows and the others, it will be no problem because those are enough rare cases.

@aladdin-add

This comment has been minimized.

Copy link
Member

commented Jul 20, 2019

just to clarify: if the user quotes like eslint "[ab].js", will have the same behavior between Windows and the others. am I reading correctly?

@mysticatea

This comment has been minimized.

Copy link
Member Author

commented Jul 21, 2019

@aladdin-add Yes. eslint "[ab].js" has the same behavior on all platforms.

@mysticatea mysticatea merged commit d08683e into master Jul 21, 2019

9 checks passed

commit-message PR title follows commit message guidelines
Details
continuous-integration Build #20190718.2 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@mysticatea mysticatea deleted the issue11940 branch Jul 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.