Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix wrong Node.js version in getting started #11993

Merged
merged 1 commit into from Jul 16, 2019

Conversation

@mysticatea
Copy link
Member

commented Jul 15, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update

What changes did you make? (Give an overview)

This PR fixes wrong Node.js version in the Getting Started page.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@g-plane

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

Should the "npm version" be updated?

@mysticatea

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2019

@g-plane I don't think so. Npm had changed the installation way largely on 3.0.0, but there is no large change since that.

@aladdin-add aladdin-add merged commit 776dae7 into master Jul 16, 2019

9 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration Build #20190715.1 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@aladdin-add aladdin-add deleted the mysticatea-patch-1 branch Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.