Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Upgrade lodash dependency (fixes #11992) #11994

Merged
merged 1 commit into from Jul 16, 2019

Conversation

@quetzaluz
Copy link
Contributor

commented Jul 15, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

  • Dependency upgrade / security fix

What changes did you make? (Give an overview)

  • Dependency upgrade

Is there anything you'd like reviewers to focus on?

@eslint eslint bot added the triage label Jul 15, 2019

@jsf-clabot

This comment has been minimized.

Copy link

commented Jul 15, 2019

CLA assistant check
All committers have signed the CLA.

@quetzaluz quetzaluz force-pushed the quetzaluz:upgrade-lodash-fix-11992 branch 2 times, most recently from bb3a140 to 758f99e Jul 15, 2019

@quetzaluz quetzaluz changed the title Fix #11992 - Upgrade lodash dependency per lodash/lodash#4348 Chore: Upgrade lodash dependency lodash/lodash#4348 (fixes #11992) Jul 15, 2019

@quetzaluz quetzaluz force-pushed the quetzaluz:upgrade-lodash-fix-11992 branch from 758f99e to bc30c2d Jul 15, 2019

@quetzaluz quetzaluz changed the title Chore: Upgrade lodash dependency lodash/lodash#4348 (fixes #11992) Upgrade: Upgrade lodash dependency (fixes #11992) Jul 15, 2019

@g-plane g-plane added chore and removed triage labels Jul 16, 2019

@g-plane
Copy link
Member

left a comment

LGTM, thanks!

@shailesh-kanzariya

This comment has been minimized.

Copy link

commented Jul 16, 2019

Thanks @quetzaluz for the fix #11992. Any idea, when this change will be available to master?

@aladdin-add
Copy link
Member

left a comment

LGTM, thanks!

@aladdin-add aladdin-add merged commit 93633c2 into eslint:master Jul 16, 2019

9 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration Build #20190715.5 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.