Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fixed a typo (fixes #11999) #12000

Merged
merged 1 commit into from Jul 17, 2019

Conversation

@olsonek
Copy link
Contributor

commented Jul 16, 2019

I adjusted a typo to match the description format of found in the Options section.

This rule takes one optional argument ...

@jsf-clabot

This comment has been minimized.

Copy link

commented Jul 16, 2019

CLA assistant check
All committers have signed the CLA.

@eslint eslint bot added the triage label Jul 16, 2019

@platinumazure
Copy link
Member

left a comment

LGTM, thanks!

Note to merger: Prefix commit summary with "Docs: " on merge.

@olsonek

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

I'm actually currently working out how to amend my commit message.

@olsonek olsonek force-pushed the olsonek:patch-1 branch from d1aa2f1 to 8d50eac Jul 16, 2019

@platinumazure

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

@olsonek Thanks, looks good now!

@g-plane g-plane changed the title Fixed a typo (fixes #11999) Docs: Fixed a typo (fixes #11999) Jul 16, 2019

@aladdin-add
Copy link
Member

left a comment

LGTM, thanks!

@aladdin-add aladdin-add merged commit 89412c3 into eslint:master Jul 17, 2019

9 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration Build #20190716.6 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.