Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update release script for new website repo #12006

Merged
merged 1 commit into from Jul 19, 2019

Conversation

@kaicataldo
Copy link
Member

commented Jul 19, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Update release script

What changes did you make? (Give an overview)
refs eslint/website#576

This updates the release script now that we've change the website repository name to eslint/website.

Is there anything you'd like reviewers to focus on?

I've already changed the repository name, turned off publishing to GitHub Pages, and have updated the Jenkins script. Did I miss anything?

@eslint eslint bot added the triage label Jul 19, 2019

@kaicataldo kaicataldo added chore and removed triage labels Jul 19, 2019

@kaicataldo kaicataldo force-pushed the update-release-script branch from 577d8bf to bfd6eee Jul 19, 2019

@platinumazure
Copy link
Member

left a comment

LGTM, thanks.

Do we want to maybe use a name like "eslint-website"? It could be a pain if someone has their own "website" repo in their GitHub project directory. It's not a problem for me, at least.

@kaicataldo

This comment has been minimized.

Copy link
Member Author

commented Jul 19, 2019

That’s an interesting point. Do you mean to rename the repository or just the name of the directory when we clone it in the release script? My inclination is that it’s probably fine as is since the releases are mostly run in Jenkins, but I don’t have a strong opinion and am happy to change it if others are concerned!

@mysticatea

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

I think that we should move the script to eslint/website repo. Because eslint/website repo depends on eslint package, it can update the website without sibling directories.

@kaicataldo

This comment has been minimized.

Copy link
Member Author

commented Jul 19, 2019

@mysticatea That sounds good to me. How do you feel about landing this first (just to make sure we’re not blocking the upcoming release)?

@mysticatea
Copy link
Member

left a comment

👍

@kaicataldo

This comment has been minimized.

Copy link
Member Author

commented Jul 19, 2019

As a side benefit, if we run the eslint release first and then run the site generation afterwards, we can also bundle eslint and espree in eslint/website as well.

@kaicataldo kaicataldo merged commit c90a12c into master Jul 19, 2019

9 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration Build #20190719.2 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@kaicataldo kaicataldo deleted the update-release-script branch Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.