Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: function-call-argument-newline rule (fixes #10323) #12024

Merged
merged 1 commit into from Aug 18, 2019

Conversation

@finico
Copy link
Contributor

finico commented Jul 26, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[x] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What category of rule is this? (place an "X" next to just one item)

[x] Enforces code style
[ ] Warns about a potential error
[ ] Suggests an alternate way of doing something
[ ] Other (please specify:)

What changes did you make? (Give an overview)
All information about this rule in #10323

Is there anything you'd like reviewers to focus on?
I didn't add indentations in fixers. But I've checked other rules and they don't do it as well..

@eslint eslint bot added the triage label Jul 26, 2019
@finico finico force-pushed the finico:issue10323 branch from 8da1765 to f6f1feb Jul 26, 2019
@finico finico force-pushed the finico:issue10323 branch from f6f1feb to f8d68dd Jul 26, 2019
@platinumazure platinumazure changed the title New: function-call-argument-newline rule (fixes: #10323) New: function-call-argument-newline rule (fixes #10323) Jul 27, 2019
Copy link
Member

platinumazure left a comment

Hi @finico, thanks for the PR!

This looks good to me at a glance, but I would like to give other team members a chance to review. Thanks for contributing!

Copy link
Member

kaicataldo left a comment

LGTM. Thanks for contributing to ESLint!

@kaicataldo

This comment has been minimized.

Copy link
Member

kaicataldo commented Jul 27, 2019

Re indentation in fixers: since we have a multi-pass autofix system, we try to keep fixes to the minimum changes necessary and let other rules handle autofixing things they warn about. The indentation rule would fix this, so this is correct 👍.

@platinumazure platinumazure merged commit 8cd00b3 into eslint:master Aug 18, 2019
9 checks passed
9 checks passed
commit-message Commit message follows guidelines
Details
continuous-integration Build #20190726.5 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Aug 18, 2019

Merged. Thanks for contributing! Sorry for the delay in getting this in.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.