/ eslint Public
Fix: Check literal type explicitly in dot-notation #12095
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix
This is a small fix that prevents
bigintand some regex literals to
nullin Node 8.
Demo link - the error is observable if you open this link in Firefox (which also doesn't support the syntax, like Node 8).
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
Please show your full configuration:
What did you do? Please include the actual source code causing the issue.
What did you expect to happen?
What actually happened? Please include the actual, raw output from ESLint.
Warning and the fix:
What changes did you make? (Give an overview)
dot-notationto explicitly check only
Is there anything you'd like reviewers to focus on?
The test in
validfails in Node 8 before the fix. Tests in
invalidare for regression only.