Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: no-self-assign false positive with rest and spread in array #12099

Merged
merged 1 commit into from Aug 26, 2019

Conversation

@mdjermanovic
Copy link
Member

mdjermanovic commented Aug 14, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix

Tell us about your environment

  • ESLint Version: 6.1.0
  • Node Version: 10.16.0
  • npm Version: 6.9.0

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

Configuration
module.exports = {
  parserOptions: {
    ecmaVersion: 2015,
  },
};

What did you do? Please include the actual source code causing the issue.

/*eslint no-self-assign: "error"*/

let a = [];

[...a] = [...a, 1]

console.log(a); // [ 1 ]

What did you expect to happen?

No errors as this is not a self assign.

What actually happened? Please include the actual, raw output from ESLint.

'a' is assigned to itself no-self-assign error

What changes did you make? (Give an overview)

Skip comparing a rest element if it isn't vs the last element.

Is there anything you'd like reviewers to focus on?

@eslint eslint bot added the triage label Aug 14, 2019
@kaicataldo kaicataldo added bug evaluating rule and removed triage labels Aug 19, 2019
Copy link
Member

kaicataldo left a comment

Thanks, this generally seems like a good idea to me! Can we add a test case for [...a, b] = [...a, 1]? Whoops, this isn't valid syntax. Please ignore!

@kaicataldo

This comment has been minimized.

Copy link
Member

kaicataldo commented Aug 19, 2019

I have verified this bug using our demo.

@kaicataldo kaicataldo added accepted and removed evaluating labels Aug 19, 2019
Copy link
Member

kaicataldo left a comment

LGTM. Thanks for contributing!

Copy link
Member

platinumazure left a comment

LGTM, thanks!

@kaicataldo kaicataldo merged commit 644ce33 into eslint:master Aug 26, 2019
9 checks passed
9 checks passed
commit-message Commit message follows guidelines
Details
continuous-integration Build #20190814.3 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@kaicataldo

This comment has been minimized.

Copy link
Member

kaicataldo commented Aug 26, 2019

Thanks for contributing to ESLint!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.