Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: func-name-matching crash on descriptor-like arguments #12100

Merged
merged 1 commit into from Aug 26, 2019

Conversation

@mdjermanovic
Copy link
Member

mdjermanovic commented Aug 15, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix

Tell us about your environment

  • ESLint Version: 6.1.0
  • Node Version: 10.16.0
  • npm Version: 6.9.0

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

Configuration
module.exports = {
  parserOptions: {
    ecmaVersion: 2015,
  },
};

What did you do? Please include the actual source code causing the issue.

/*eslint func-name-matching: ["error", { "considerPropertyDescriptor": true }]*/

foo({ value: function bar() {} })

What did you expect to happen?

Not to crash.

What actually happened? Please include the actual, raw output from ESLint.

TypeError: Cannot read property 'name' of undefined

What changes did you make? (Give an overview)

Fixed the bug.

Is there anything you'd like reviewers to focus on?

There is still a number of places where the rule can crash or produce false positives on a designed example, as the code doesn't check parent types, correct index of the child in parent's arguments, existence and types of other arguments from which it reads etc.

The example which is fixed in this PR can easily occur in a real code, so it might make sense to fix just this at the moment.

For the rest, I believe it would be better to make helpers in astUtils as there are at least 3 other rules that also work with descriptors and have a very similar code (and some small bugs as well).

@eslint eslint bot added the triage label Aug 15, 2019
@g-plane g-plane added accepted bug rule and removed triage labels Aug 20, 2019
@g-plane

This comment has been minimized.

Copy link
Member

g-plane commented Aug 20, 2019

I can reproduce it on demo.

Copy link
Member

g-plane left a comment

LGTM, thanks!

Copy link
Member

kaicataldo left a comment

LGTM. Thanks!

Copy link
Member

platinumazure left a comment

LGTM, thanks!

@kaicataldo kaicataldo merged commit 197f443 into eslint:master Aug 26, 2019
9 checks passed
9 checks passed
commit-message Commit message follows guidelines
Details
continuous-integration Build #20190815.1 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@kaicataldo

This comment has been minimized.

Copy link
Member

kaicataldo commented Aug 26, 2019

Thanks for contributing to ESLint!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.