Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add duplicate keys limitation to accessor-pairs #12124

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@mdjermanovic
Copy link
Member

mdjermanovic commented Aug 19, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update

Additional documentation for accessor-pairs

conversation in PR #12062

What changes did you make? (Give an overview)

Added an example with duplicate keys to the Known Limitations section.

Is there anything you'd like reviewers to focus on?

@eslint eslint bot added the triage label Aug 19, 2019
Copy link
Member

platinumazure left a comment

LGTM, thanks!

Copy link
Member

kaicataldo left a comment

LGTM. Thanks for following up on this!

@kaicataldo kaicataldo merged commit 6886148 into eslint:master Aug 19, 2019
9 checks passed
9 checks passed
commit-message Commit message follows guidelines
Details
continuous-integration Build #20190819.11 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor This change is semver-patch
Details
@eslint eslint bot locked and limited conversation to collaborators Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.