Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix wrong error object keys in test files #12162

Merged
merged 1 commit into from Aug 26, 2019
Merged

Chore: Fix wrong error object keys in test files #12162

merged 1 commit into from Aug 26, 2019

Conversation

@mdjermanovic
Copy link
Member

mdjermanovic commented Aug 25, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Other, please explain:

What changes did you make? (Give an overview)

Fixed test cases that had nodeType instead of type and various typos like messgeId in 6 files.

Is there anything you'd like reviewers to focus on?

no-extra-parens tests are fixed in #12142. Other test files are OK in regard to this.

@eslint eslint bot added the triage label Aug 25, 2019
@mdjermanovic mdjermanovic added the chore label Aug 25, 2019
Copy link
Member

platinumazure left a comment

LGTM, thanks!

@platinumazure platinumazure added accepted and removed triage labels Aug 25, 2019
Copy link
Member

kaicataldo left a comment

LGTM. Thanks for fixing this!

@kaicataldo kaicataldo merged commit 31e5428 into master Aug 26, 2019
9 checks passed
9 checks passed
commit-message Commit message follows guidelines
Details
continuous-integration Build #20190825.1 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@kaicataldo

This comment has been minimized.

Copy link
Member

kaicataldo commented Aug 26, 2019

Thanks for contributing to ESLint!

@platinumazure platinumazure deleted the test-typos branch Aug 26, 2019
@eslint eslint bot locked and limited conversation to collaborators Feb 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.