Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: yoda rule produces invalid autofix with preceding yield #12166

Merged
merged 1 commit into from Aug 30, 2019
Merged

Conversation

@mdjermanovic
Copy link
Member

mdjermanovic commented Aug 25, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix

Tell us about your environment

  • ESLint Version: 6.2.2
  • Node Version: 10.16.0
  • npm Version: 6.9.0

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

Configuration
module.exports = {
  parserOptions: {
    ecmaVersion: 2015,
  },
};

What did you do? Please include the actual source code causing the issue.

Demo link 1

/*eslint yoda: ["error", "never"]*/

function *foo() {
  yield(1) < a;
}

Demo link 2

/*eslint yoda: ["error", "always"]*/

function *foo() {
  yield++a < 1;
}

What did you expect to happen?

Fix to:

/*eslint yoda: ["error", "never"]*/

function *foo() {
  yield a > (1);
}
/*eslint yoda: ["error", "always"]*/

function *foo() {
  yield 1 > ++a;
}

What actually happened? Please include the actual, raw output from ESLint.

Fixed to:

/*eslint yoda: ["error", "never"]*/

function *foo() {
  yielda > (1);
}
/*eslint yoda: ["error", "always"]*/

function *foo() {
  yield1 > ++a;
}

What changes did you make? (Give an overview)

Fixed the fixer to check can the tokens be adjacent.

Is there anything you'd like reviewers to focus on?

Only these tests were failing, others are regression tests:

function *foo() { yield(1) < a }
function *foo() { yield((1)) < a }
function *foo() { yield++a < 1 }
function *foo() { yield(a) < 1 }
@eslint eslint bot added the triage label Aug 25, 2019
@platinumazure platinumazure added accepted and removed triage labels Aug 25, 2019
Copy link
Member

platinumazure left a comment

LGTM, thanks!

Copy link
Member

btmills left a comment

LGTM, thanks!

@kaicataldo kaicataldo merged commit 4009d39 into master Aug 30, 2019
9 checks passed
9 checks passed
commit-message Commit message follows guidelines
Details
continuous-integration Build #20190825.3 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@kaicataldo

This comment has been minimized.

Copy link
Member

kaicataldo commented Aug 30, 2019

Thanks for contributing!

@mdjermanovic mdjermanovic deleted the yoda-fixer branch Aug 30, 2019
@eslint eslint bot locked and limited conversation to collaborators Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.