Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: support TypeScript at config initializer (fixes #11789) #12172

Merged
merged 3 commits into from Aug 30, 2019
Merged

Conversation

@g-plane
Copy link
Member

g-plane commented Aug 27, 2019

What is the purpose of this pull request? (put an "X" next to item)

[x] Add a CLI option

What changes did you make? (Give an overview)
Added a new CLI option for TypeScript.

Is there anything you'd like reviewers to focus on?
Should we add a separated CLI option for TypeScript? Or add it to an existing one?

@eslint eslint bot added the triage label Aug 27, 2019
@g-plane g-plane added accepted cli enhancement and removed triage labels Aug 27, 2019
g-plane added 2 commits Aug 27, 2019
@g-plane g-plane marked this pull request as ready for review Aug 28, 2019
@aladdin-add aladdin-add self-requested a review Aug 28, 2019
Copy link
Member

kaicataldo left a comment

LGTM!

@kaicataldo

This comment has been minimized.

Copy link
Member

kaicataldo commented Aug 30, 2019

Thanks for contributing!

@kaicataldo kaicataldo merged commit 4c0b70b into master Aug 30, 2019
9 checks passed
9 checks passed
commit-message PR title follows commit message guidelines
Details
continuous-integration Build #20190827.3 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@g-plane g-plane deleted the issue-11789 branch Aug 30, 2019
@eslint eslint bot locked and limited conversation to collaborators Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.