Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: enable default-param-last #12244

Merged

Conversation

@aladdin-add
Copy link
Member

aladdin-add commented Sep 8, 2019

note: this is a breaking change in eslint-config-eslint.

refs:0313441

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain: just dog fooding the new rule. :-)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?
not really.

note: this is a breaking change in eslint-config-eslint.

refs:0313441
@aladdin-add aladdin-add force-pushed the aladdin-add:chore/enable-default-param-last branch from 2807290 to cb84207 Sep 8, 2019
Copy link
Member

platinumazure left a comment

LGTM, thanks!

@aladdin-add aladdin-add merged commit f9fc695 into eslint:master Sep 14, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20190908.12 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor This change is semver-patch
Details
@aladdin-add aladdin-add deleted the aladdin-add:chore/enable-default-param-last branch Sep 14, 2019
@eslint eslint bot locked and limited conversation to collaborators Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.