Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: add no-import-assign (fixes #12237) #12252

Merged
merged 6 commits into from Sep 14, 2019

Conversation

@mysticatea
Copy link
Member

commented Sep 10, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] New rule: fixes #12237.

What changes did you make? (Give an overview)

This PR adds a new rule no-import-assign.

Is there anything you'd like reviewers to focus on?

  • Is documentation enough?
  • Are tests enough?
mysticatea added 2 commits Sep 10, 2019
@mysticatea

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

I have updated this rule to follow the review!

tests/lib/rules/no-import-assign.js Show resolved Hide resolved
tests/lib/rules/no-import-assign.js Outdated Show resolved Hide resolved
tests/lib/rules/no-import-assign.js Outdated Show resolved Hide resolved
tests/lib/rules/no-import-assign.js Outdated Show resolved Hide resolved
@mysticatea

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

I have updated this rule to follow the review!

@mdjermanovic
Copy link
Member

left a comment

LGTM :)

Maybe just one more import mod, * as mod_ns from 'mod' test that mutates both, but errors only mod_ns

@ilyavolodin ilyavolodin merged commit 1c921c6 into master Sep 14, 2019

16 checks passed

Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message PR title follows commit message guidelines
Details
continuous-integration Build #20190912.7 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@ilyavolodin ilyavolodin deleted the issue12237 branch Sep 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.