Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: space-before-function-paren autofix removes comments (fixes #12259) #12264

Merged
merged 1 commit into from Sep 14, 2019

Conversation

@mdjermanovic
Copy link
Member

mdjermanovic commented Sep 12, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix #12259

This PR fixes the space-before-function-paren rule fixer with the "never" option, to:

  • Concatenate block comments instead of removing them.
  • Report error but doesn't fix anything if there is a line comment between.

Example:

Demo link

/* eslint space-before-function-paren:["error", "never"]*/

function foo /* */(){}

function bar /* 1 */
/* 2 */
/* 3 */ (){}

function baz // line comment
(){}

Current autofix behavior:

/* eslint space-before-function-paren:["error", "never"]*/

function foo(){}

function bar(){}

function baz(){}

New autofix behavior:

/* eslint space-before-function-paren:["error", "never"]*/

function foo/* */(){}

function bar/* 1 *//* 2 *//* 3 */(){}

function baz // line comment
(){}

baz is reported, but not auto-fixed.

What changes did you make? (Give an overview)

Modified the fixer to work similar to template-tag-spacing.

Is there anything you'd like reviewers to focus on?

@eslint eslint bot added the triage label Sep 12, 2019
@mdjermanovic mdjermanovic added accepted bug rule and removed triage labels Sep 12, 2019
Copy link
Member

mysticatea left a comment

LGTM as aligned the behavior to the existing rules.

I think that we should separate the space style around comments to another rule in the future.

@mysticatea mysticatea merged commit 985c9e5 into master Sep 14, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20190912.9 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@mysticatea mysticatea deleted the issue12259 branch Sep 14, 2019
@eslint eslint bot locked and limited conversation to collaborators Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.