Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: enable prefer-regex-literals in eslint codebase #12268

Merged
merged 1 commit into from Dec 20, 2019
Merged

Conversation

@aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Sep 14, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ x] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?
this is a breaking change in eslint-config-eslint.

@kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented Dec 14, 2019

Is there a reason this is any more a breaking change than other updates we've made to eslint-config-eslint?

@aladdin-add
Copy link
Member Author

@aladdin-add aladdin-add commented Dec 16, 2019

if follows the the same policy with eslint:recommended, it is a breaking change :)

just curious what's other popular shared configs' semantic versioning policy?

@platinumazure
Copy link
Member

@platinumazure platinumazure commented Dec 16, 2019

This is a breaking change from the perspective of the eslint-config-eslint package, but that doesn't mean we need to hold this behind the ESLint major release.

We can release breaking changes to eslint-config-eslint more frequently, because in theory, only the ESLint team needs to update packages to consume the new configuration. And even if not, users have to choose to use eslint-config-eslint (and install it as its own package), so users should know the semver rules and should understand what they are choosing to do if they use that package.

On the other hand, updating eslint:recommended changes the recommended experience right in ESLint itself and it's not a separate package. So any changes made there must be semver-major in ESLint itself (although there are exceptions for removing rules from recommended, noted explicitly in our semver policy).

@btmills btmills merged commit 4b3cc5c into master Dec 20, 2019
16 checks passed
16 checks passed
@github-actions
Verify Files
Details
@github-actions
Test (ubuntu-latest, 8.x)
Details
@github-actions
Test (ubuntu-latest, 10.x)
Details
@github-actions
Test (ubuntu-latest, 12.x)
Details
@github-actions
Test (windows-latest, 12.x)
Details
@github-actions
Test (macOS-latest, 12.x)
Details
@github-actions
Browser Test
Details
@eslint-deprecated
commit-message Commit message follows guidelines
Details
@azure-pipelines
continuous-integration Build #20190914.18 succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
@eslint-deprecated
release-monitor No patch release is pending
Details
@btmills btmills deleted the aladdin-add-patch-1 branch Dec 20, 2019
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants