Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update globals to v12.1.0 #12296

Merged
merged 1 commit into from Oct 29, 2019
Merged

update globals to v12.1.0 #12296

merged 1 commit into from Oct 29, 2019

Conversation

@UziTech
Copy link
Contributor

UziTech commented Sep 21, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Update dependency

What changes did you make? (Give an overview)

Update globals dependency to v12.1.0 Here are the changes

Most notably for me is the addition of globals to the jasmine environment:
expectAsync and spyOnAllFunctions

Is there anything you'd like reviewers to focus on?

No

@jsf-clabot
Copy link

jsf-clabot commented Sep 21, 2019

CLA assistant check
All committers have signed the CLA.

@eslint eslint bot added the triage label Sep 21, 2019
@UziTech UziTech force-pushed the UziTech:patch-1 branch from 6db58c1 to 88710c6 Sep 21, 2019
@UziTech UziTech force-pushed the UziTech:patch-1 branch from 88710c6 to 8670896 Sep 21, 2019
@kaicataldo kaicataldo added evaluating upgrade and removed triage labels Sep 21, 2019
@kaicataldo
Copy link
Member

kaicataldo commented Sep 21, 2019

sindresorhus/globals#143 looks like the only change that would affect existing globals. It looks like it'll lead to fewer errors, though, so I think it's fine to release this as a semver-minor bug fix.

@UziTech
Copy link
Contributor Author

UziTech commented Oct 27, 2019

Is there anything blocking this?

@ilyavolodin
Copy link
Member

ilyavolodin commented Oct 27, 2019

No, sorry, we lost track of this PR. Thanks for the reminder. We are currently in merge freeze due to possibility of patch release, but once we are out of it, we'll merge this in.

@ilyavolodin ilyavolodin self-assigned this Oct 27, 2019
@ilyavolodin ilyavolodin added accepted and removed evaluating labels Oct 29, 2019
@ilyavolodin ilyavolodin merged commit 98e1d50 into eslint:master Oct 29, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20190921.3 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.