Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: no-undef-init autofix removes comments #12299

Merged
merged 1 commit into from Sep 29, 2019
Merged

Conversation

@mdjermanovic
Copy link
Member

mdjermanovic commented Sep 22, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix

Tell us about your environment

  • ESLint Version: 6.4.0
  • Node Version: 10.16.0
  • npm Version: 6.9.0

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

Configuration
module.exports = {
  parserOptions: {
    ecmaVersion: 2015,
  }
};

What did you do? Please include the actual source code causing the issue.

Demo link

/* eslint no-undef-init:error */

let a /* comment */ = undefined;

let b = // comment
    undefined;

What did you expect to happen?

2 errors, but not to remove comments.

What actually happened? Please include the actual, raw output from ESLint.

/* eslint no-undef-init:error */

let a;

let b;

What changes did you make? (Give an overview)

Report errors but don't fix if that would remove any comments.

Is there anything you'd like reviewers to focus on?

@eslint eslint bot added the triage label Sep 22, 2019
Copy link
Member

kaicataldo left a comment

LGTM!

@kaicataldo

This comment has been minimized.

Copy link
Member

kaicataldo commented Sep 22, 2019

Hmmm, looks like we have a flaky test (not necessarily related to this change) in the test suite.

@kaicataldo

This comment has been minimized.

Copy link
Member

kaicataldo commented Sep 22, 2019

Looks like https://github.com/eslint/eslint/pull/12290/checks?check_run_id=228384386 is failing in the same environment (though it looks like it timed out in the install rather than the test run phase).

@mdjermanovic

This comment has been minimized.

Copy link
Member Author

mdjermanovic commented Sep 22, 2019

Could be a problem with CI / Test (macOS-latest, 12.x), it also failed in #12290 but for a different reason.

@kaicataldo

This comment has been minimized.

Copy link
Member

kaicataldo commented Sep 22, 2019

Yeah, seems likely it's an issue with GitHub Hooks. I don't think we need to hold up either PR for this, especially since it's passing in Azure Pipelines in macOS.

Copy link
Member

platinumazure left a comment

LGTM, thanks!

@platinumazure platinumazure merged commit acec201 into master Sep 29, 2019
15 of 16 checks passed
15 of 16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20190922.1 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@platinumazure platinumazure deleted the noundefinit-comments branch Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.