Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Fix handling of chained new expressions in new-parens #12303

Merged
merged 1 commit into from Sep 29, 2019

Conversation

@mdjermanovic
Copy link
Member

mdjermanovic commented Sep 23, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix

This bug fix can produce more errors by the new-parens rule in some cases. Also fixes wrong autofix in some other cases.

Tell us about your environment

  • ESLint Version: 6.4.0
  • Node Version: 10.16.0
  • npm Version: 6.9.0

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

Configuration
module.exports = {
  parserOptions: {
    ecmaVersion: 2015,
  }
};

What did you do? Please include the actual source code causing the issue.

Demo link 1

/* eslint new-parens:["error", "always"] */

new new foo();

Demo link 2

/* eslint new-parens:["error", "never"] */

new new foo();

What did you expect to happen?

1 error and the following autofix for the first example:

/* eslint new-parens:["error", "always"] */

new new foo()();

1 error and the following autofix for the second example:

/* eslint new-parens:["error", "never"] */

new (new foo);

What actually happened? Please include the actual, raw output from ESLint.

0 errors in the first example:

/* eslint new-parens:["error", "always"] */

// false negative, the outer `new` does not have parens.
new new foo();

2 errors and a bit invalid autofix in the second example:

/* eslint new-parens:["error", "never"] */

// false positive for the outer `new` and invalid autofix - wrong place for parens
(new new foo);

What changes did you make? (Give an overview)

Check that the parens are not a part of the child node.

Is there anything you'd like reviewers to focus on?

@eslint eslint bot added the triage label Sep 23, 2019
@platinumazure platinumazure added accepted bug rule and removed triage labels Sep 29, 2019
@platinumazure platinumazure requested a review from mysticatea Sep 29, 2019
Copy link
Member

mysticatea left a comment

LGTM, thank you!

@mysticatea mysticatea merged commit 41bfe91 into master Sep 29, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20190923.3 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@mysticatea mysticatea deleted the newparens-chained branch Sep 29, 2019
@eslint eslint bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.