Fix: problematic installation issue (fixes #11018) #12309
Merged
Conversation
|
This PR is ready for review. |
|
LGTM, thanks! |
b3dbd96
into
master
17 checks passed
17 checks passed
continuous-integration (Test on Node.js 12 (Windows))
Test on Node.js 12 (Windows) succeeded
Details
This was referenced Nov 9, 2019
This was referenced Mar 11, 2020
This was referenced Mar 26, 2020
This was referenced Apr 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
WIP.Done.acornintroduces a new mechanism that plugins access the actually appliedacornentity.acorn-jsxplugin uses the mechanism.espreeplugin uses the mechanism.eslintuses the updatedespree.What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix: #11018
What changes did you make? (Give an overview)
This PR fixes #11018 as using the new mechanism that acorn plugins can access the actually applied acorn entity.
The problem has happened when the two acorns are different entities.
acornthat is using plugins.acornthat the plugins imported byrequire("acorn").After this PR,
acornplugins get to not userequire("acorn").Is there anything you'd like reviewers to focus on?
I'm not sure how I add tests.
You can confirm that this PR fixes the problem:
node_moduleshas the following structure.