Docs: 1tbs with allowSingleLine edge cases (refs #12284) #12314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
kardasis
force-pushed
the
1tbs-allowSingleLine-hybrid
branch
from
e5f01b2
to
0f177d5
Compare
kardasis
changed the title
kardasis
force-pushed
the
1tbs-allowSingleLine-hybrid
branch
from
0f177d5
to
33b47e4
Compare
Add documentation and tests demonstrating iffy edge cases
kardasis
force-pushed
the
1tbs-allowSingleLine-hybrid
branch
from
33b47e4
to
fe8721b
Compare
kardasis
changed the title
kaicataldo
added
documentation
|
Thanks for doing this - this is a great way to evaluate this behavior! |
kaicataldo
approved these changes
Dec 14, 2019
kaicataldo
added
accepted
|
Apologies for the delay. Thanks for the contributing! |
This was referenced Jan 12, 2020
This was referenced Mar 11, 2020
This was referenced Mar 26, 2020
This was referenced Apr 3, 2020
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add documentation and tests demonstrating iffy edge cases
What is the purpose of this pull request? (put an "X" next to item)
[ x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x ] Other, please explain: Additional tests
What changes did you make? (Give an overview)
Added tests and documentation for 1tbs with allowSingleLine
Is there anything you'd like reviewers to focus on?
Looking for some feedback about whether these examples are desirable