Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: 1tbs with allowSingleLine edge cases (refs #12284) #12314

Merged
merged 1 commit into from Dec 14, 2019

Conversation

@kardasis
Copy link
Contributor

@kardasis kardasis commented Sep 26, 2019

add documentation and tests demonstrating iffy edge cases

What is the purpose of this pull request? (put an "X" next to item)

[ x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x ] Other, please explain: Additional tests

What changes did you make? (Give an overview)
Added tests and documentation for 1tbs with allowSingleLine

Is there anything you'd like reviewers to focus on?
Looking for some feedback about whether these examples are desirable

@kardasis kardasis force-pushed the kardasis:1tbs-allowSingleLine-hybrid branch from e5f01b2 to 0f177d5 Sep 26, 2019
@kardasis kardasis changed the title docs: (ref #12284) Docs: 1tbs with allowSingleLine edge cases (ref #12284) Sep 26, 2019
@kardasis kardasis force-pushed the kardasis:1tbs-allowSingleLine-hybrid branch from 0f177d5 to 33b47e4 Sep 26, 2019
Add documentation and tests demonstrating iffy edge cases
@kardasis kardasis force-pushed the kardasis:1tbs-allowSingleLine-hybrid branch from 33b47e4 to fe8721b Sep 26, 2019
@kardasis kardasis changed the title Docs: 1tbs with allowSingleLine edge cases (ref #12284) Docs: 1tbs with allowSingleLine edge cases (refs #12284) Sep 26, 2019
@kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented Sep 26, 2019

Thanks for doing this - this is a great way to evaluate this behavior!

Copy link
Member

@kaicataldo kaicataldo left a comment

This LGTM. Agreed that some of these cases are a bit strange, but I think we should merge this as-is since it better documents the current behavior.

@kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented Dec 14, 2019

Apologies for the delay. Thanks for the contributing!

@kaicataldo kaicataldo merged commit ab912f0 into eslint:master Dec 14, 2019
16 checks passed
16 checks passed
@github-actions
Verify Files
Details
@github-actions
Test (ubuntu-latest, 8.x)
Details
@github-actions
Test (ubuntu-latest, 10.x)
Details
@github-actions
Test (ubuntu-latest, 12.x)
Details
@github-actions
Test (windows-latest, 12.x)
Details
@github-actions
Test (macOS-latest, 12.x)
Details
@github-actions
Browser Test
Details
@eslint-deprecated
commit-message Commit message follows guidelines
Details
@azure-pipelines
continuous-integration Build #20190926.4 succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
@eslint-deprecated
release-monitor No patch release is pending
Details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants