Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: improve report location for no-mixed-operators #12328

Merged
merged 1 commit into from Oct 21, 2019
Merged

Update: improve report location for no-mixed-operators #12328

merged 1 commit into from Oct 21, 2019

Conversation

@golopot
Copy link
Contributor

@golopot golopot commented Sep 27, 2019

What is the purpose of this pull request? (put an "X" next to item)
[x] Changes an existing rule

What changes did you make? (Give an overview)
Make no-mixed-operators report both start and end location, instead of only start location.

let p = a && b || c
//        ~    ~    before
//        ~~   ~~   after
 

Is there anything you'd like reviewers to focus on?
No

Copy link
Member

@kaicataldo kaicataldo left a comment

LGTM, thanks!

@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Oct 20, 2019

LGTM, thanks!

One more 👍 to accept.

@platinumazure platinumazure added accepted and removed evaluating labels Oct 21, 2019
@platinumazure
Copy link
Member

@platinumazure platinumazure commented Oct 21, 2019

This is now accepted!

@platinumazure platinumazure merged commit 349ed67 into eslint:master Oct 21, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20190927.16 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@golopot golopot deleted the golopot:no-mixed-operators-report-location branch Mar 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants