Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add autofix npm script #12330

Merged
merged 1 commit into from Sep 29, 2019
Merged

Chore: add autofix npm script #12330

merged 1 commit into from Sep 29, 2019

Conversation

@kaicataldo
Copy link
Member

kaicataldo commented Sep 28, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)
This adds a fix flag to the lint task in Makefile.js and adds a fix npm script as a small convenience for contributors.

Is there anything you'd like reviewers to focus on?
Nothing in particular!

@eslint eslint bot added the triage label Sep 28, 2019
@kaicataldo kaicataldo added chore and removed triage labels Sep 28, 2019
Copy link
Member

platinumazure left a comment

LGTM, thanks!

Probably overthinking this, but: Should we handle differently in case this is called from CI? (It shouldn't be, but...)

@kaicataldo

This comment has been minimized.

Copy link
Member Author

kaicataldo commented Sep 28, 2019

@platinumazure Mind elaborating on what you mean? Not sure I understand. Thanks!

@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Sep 28, 2019

I was just wondering if we wanted to have an environment variable check in that task, where if the task was called from CI, then it should throw an error.

As I type this, I'm thinking not, so go ahead and just ignore what I said.

@platinumazure platinumazure requested a review from mysticatea Sep 29, 2019
Copy link
Member

mysticatea left a comment

LGTM, thank you!

@mysticatea mysticatea merged commit 160b7c4 into master Sep 29, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20190928.3 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@mysticatea mysticatea deleted the add-fix-script branch Sep 29, 2019
@eslint eslint bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.