Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: no-useless-rename handles ExperimentalRestProperty (fixes #12335) #12339

Merged
merged 1 commit into from Oct 1, 2019

Conversation

@kaicataldo
Copy link
Member

commented Sep 29, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

fixes #12335

What changes did you make? (Give an overview)

#12322 removed the check for ExperimentalRestProperty, causing the rule to crash with babel-eslint. This will be fixed by babel/babel-eslint#785 on the babel-eslint side.

Is there anything you'd like reviewers to focus on?

Nothing in particular!

@kaicataldo kaicataldo force-pushed the fix-12335 branch from dada624 to 3c2083b Sep 29, 2019
Copy link
Member

left a comment

LGTM, thanks!

@ljharb
ljharb approved these changes Sep 29, 2019
Copy link
Member

left a comment

LGTM, thanks!

@mysticatea mysticatea merged commit 447ac87 into master Oct 1, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20190929.24 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor This change is semver-patch
Details
@mysticatea mysticatea deleted the fix-12335 branch Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.